Skip to content

feat: Add pull request fields to Repository#4268

Merged
gmlewis merged 2 commits into
google:masterfrom
ap-1:add-repository-pull-request-fields
Jun 5, 2026
Merged

feat: Add pull request fields to Repository#4268
gmlewis merged 2 commits into
google:masterfrom
ap-1:add-repository-pull-request-fields

Conversation

@ap-1
Copy link
Copy Markdown
Contributor

@ap-1 ap-1 commented Jun 3, 2026 •
edited
Loading

Adds HasPullRequests and PullRequestCreationPolicy to Repository. Accessors and stringify tests regenerated via script/generate.sh.

Closes #4267

@ap-1 ap-1 mentioned this pull request Jun 3, 2026
Open
7 tasks
@gmlewis gmlewis changed the title feat: Add pull request fields to Repository feat: Add pull request fields to Repository Jun 3, 2026
@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Jun 3, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 3, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.49%. Comparing base (a61969a) to head (62c3311).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #4268   +/-   ##
=======================================
  Coverage   97.48%   97.49%           
=======================================
  Files         192      192           
  Lines       19227    19230    +3     
=======================================
+ Hits        18744    18748    +4     
+ Misses        268      267    -1     
  Partials      215      215

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

gmlewis
gmlewis approved these changes Jun 3, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @ap-1!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.

cc: @stevehipwell - @alexandear - @zyfy29 - @Not-Dhananjay-Mishra - @munlicode

alexandear
alexandear reviewed Jun 4, 2026
View reviewed changes
Comment thread github/repos.go Outdated
@ap-1
Copy link
Copy Markdown
Contributor Author

ap-1 commented Jun 4, 2026

@alexandear thanks for catching this! I confirmed that these fields don't exist for POST /orgs/{org}/repos and POST /user/repos. I removed them from createRepoRequest and the Create mapping.

It seems like they're only honored by PATCH /repos/{owner}/{repo}, so they remain on Repository (for Get/Edit).

@gmlewis gmlewis removed waiting for reply NeedsReview PR is awaiting a review before merging. labels Jun 5, 2026
@gmlewis
Copy link
Copy Markdown
Collaborator

gmlewis commented Jun 5, 2026

Thank you, @ap-1 and @alexandear!
Merging.

@gmlewis gmlewis merged commit bbd1294 into google:master Jun 5, 2026
14 checks passed
@ap-1 ap-1 deleted the add-repository-pull-request-fields branch June 5, 2026 12:45
This was referenced Jun 6, 2026
Open
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gmlewis gmlewis gmlewis approved these changes

+1 more reviewer

@alexandear alexandear alexandear approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add HasPullRequests and PullRequestCreationPolicy to Repository

3 participants

@ap-1 @gmlewis @alexandear